fix(event_handler): support finding type annotated resolver when merging schemas#8074
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
pull-request-size
bot
added
the
size/S
powertools-for-aws-oss-automation
bot
added
size/S
siwyd
changed the title
|
@anafalcao Hi! I changed the PR title to try and pass the Semantic PR check, but it doesn't seem like it retriggers automatically? Can I trigger it myself somehow again? |
powertools-for-aws-oss-automation
bot
added
size/S
powertools-for-aws-oss-automation
bot
added
size/M
|
leandrodamascena
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8074 +/- ##
========================================
Coverage 96.64% 96.65%
========================================
Files 282 282
Lines 13791 13798 +7
Branches 1102 1103 +1
========================================
+ Hits 13329 13336 +7
Misses 339 339
Partials 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
Thanks for fixing this @siwyd! I missed this when building this new feature.
I moved the test from unit to functional and added a new handler to test this. While your unit test was good, I prefer to have this as a function test and test the functionally working with a real Lambda.
APPROVED! Thanks a lot.
leandrodamascena
merged commit dafed6a
into
aws-powertools:develop
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
|
@leandrodamascena Thanks for the quick merge. Yeah, functional test makes sense, that better replicates my confusion when investigating this 😆 I put it in the unit tests because I spotted the other |
3 participants
Issue number: closes #8073
Summary
Changes
Support type annotated resolver finding for OpenAPI merge.
User experience
Type annotated resolver was simply not found, now it is.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.